4.39.1

.drone.yml

@@ -0,0 +1,52 @@
+
+kind: pipeline
+type: docker
+name: build-multiarch-images
+
+platform:
+  os: linux
+  arch: amd64
+
+steps:
+- name: make-tags
+  image: node
+  commands:
+    - echo -n "${DRONE_TAG}, latest" > .tags
+
+- name: build  
+  image: thegeeklab/drone-docker-buildx
+  privileged: true
+  settings:
+    provenance: false
+    dockerfile: app/Dockerfile
+    context: app
+    registry: git.mrmeeb.stream
+    username: 
+      from_secret: docker_username
+    password: 
+      from_secret: docker_password
+    repo: git.mrmeeb.stream/mrmeeb/simple-login
+    platforms:
+      - linux/arm64
+      - linux/amd64
+
+- name: notify
+  image: plugins/slack
+  when:
+    status:
+    - success
+    - failure
+    - killed
+  settings:
+    webhook: 
+      from_secret: slack_webhook
+    icon_url:
+      from_secret: slack_avatar
+
+trigger:
+  event:
+    include:
+    - tag
+  ref:
+    include:
+    - refs/tags/**

.gitea/workflows/build-release-image.yaml

@@ -1,195 +0,0 @@
-name: Build-Release-Image
-on:
-  push:
-    tags:
-      - '*'
-
-env:
-  CONTAINER_NAME: git.mrmeeb.stream/mrmeeb/simple-login-dev
-  TEA_VERSION: 0.9.2
-
-jobs:
-
-  Build-Image:
-    runs-on: [ubuntu-docker-latest, "${{ matrix.platform }}"]
-    strategy:
-      fail-fast: false
-      matrix:
-        platform:
-          - linux/amd64
-          - linux/arm64
-    steps:
-      - name: Prepare
-        run: |
-          platform=${{ matrix.platform }}
-          echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV
-          echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-      - name: Checkout
-        uses: actions/checkout@v2
-      # Not needed currently due to https://github.com/go-gitea/gitea/issues/29563
-      #- name: Prepare tags
-      #  id: meta
-      #  uses: docker/metadata-action@v5
-      #  with:
-      #    images: ${{ env.CONTAINER_NAME }}
-      #    tags: |
-      #      type=pep440,pattern={{version}}
-      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-      - name: Login to Gitea Container Registry
-        uses: docker/login-action@v3
-        with:
-          registry: git.mrmeeb.stream
-          username: ${{ env.GITHUB_ACTOR }}
-          password: ${{ secrets.GTCR_TOKEN }}
-      - name: Build and push by digest
-        uses: docker/build-push-action@v5
-        id: build
-        with:
-          context: ./app
-          platforms: ${{ matrix.platform }}
-          provenance: false
-          outputs: type=image,name=${{ env.CONTAINER_NAME }},push-by-digest=true,name-canonical=true,push=true
-      - name: Export digest
-        run: |
-          mkdir -p /tmp/digests
-          digest="${{ steps.build.outputs.digest }}"
-          touch "/tmp/digests/${digest#sha256:}"
-      - name: Upload digest
-        uses: actions/upload-artifact@v3
-        with:
-          name: digests-${{ env.PLATFORM_PAIR }}
-          path: /tmp/digests/*
-          if-no-files-found: error
-          retention-days: 1
-      - name: Notify
-        uses: rjstone/discord-webhook-notify@v1
-        if: failure()
-        with:
-          severity: ${{ job.status == 'success' && 'info' || (job.status == 'cancelled' && 'warn' || 'error') }}
-          details: Build ${{ job.status == 'success' && 'succeeded' || (job.status == 'cancelled' && 'cancelled' || 'failed') }}!
-          webhookUrl: ${{ secrets.DISCORD_WEBHOOK }}
-          username: Gitea
-          avatarUrl: ${{ vars.RUNNER_ICON_URL }}
-
-  Merge-Images:
-    runs-on: ubuntu-docker-latest
-    needs: [Build-Image]
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-      - name: Get tag
-        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-      - name: Download digests
-        uses: actions/download-artifact@v3
-        with:
-          path: /tmp/digests
-          pattern: digests-*
-          merge-multiple: true
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-      # Not needed currently due to https://github.com/go-gitea/gitea/issues/29563
-      #- name: Prepare Docker metadata
-      #  id: meta
-      #  uses: docker/metadata-action@v5
-      #  with:
-      #    images: ${{ env.CONTAINER_NAME }}
-      - name: Login to Gitea Container Registry
-        uses: docker/login-action@v3
-        with:
-          registry: git.mrmeeb.stream
-          username: ${{ env.GITHUB_ACTOR }}
-          password: ${{ secrets.GTCR_TOKEN }}
-      - name: Create manifest latest
-        working-directory: /tmp/digests
-        run: |
-          docker manifest create ${{ env.CONTAINER_NAME }}:latest \
-            --amend ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-amd64/* | cut -d / -f 2) \
-            --amend ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-arm64/* | cut -d / -f 2)
-          #docker manifest annotate --arch amd64 --os linux ${{ env.CONTAINER_NAME }}:latest ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-amd64/* | cut -d / -f 2)
-          #docker manifest annotate --arch arm64 --os linux ${{ env.CONTAINER_NAME }}:latest ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-arm64/* | cut -d / -f 2)
-          docker manifest inspect ${{ env.CONTAINER_NAME }}:latest
-
-          docker manifest push ${{ env.CONTAINER_NAME }}:latest
-      - name: Create manifest tagged
-        working-directory: /tmp/digests
-        run: |
-          docker manifest create ${{ env.CONTAINER_NAME }}:${{ env.RELEASE_VERSION }} \
-            --amend ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-amd64/* | cut -d / -f 2) \
-            --amend ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-arm64/* | cut -d / -f 2)
-          #docker manifest annotate --arch amd64 --os linux ${{ env.CONTAINER_NAME }}:${{ env.RELEASE_VERSION }} ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-amd64/* | cut -d / -f 2)
-          #docker manifest annotate --arch arm64 --os linux ${{ env.CONTAINER_NAME }}:${{ env.RELEASE_VERSION }} ${{ env.CONTAINER_NAME }}@sha256:$(ls -p digests-linux-arm64/* | cut -d / -f 2)
-          docker manifest inspect ${{ env.CONTAINER_NAME }}:${{ env.RELEASE_VERSION }}
-
-          docker manifest push ${{ env.CONTAINER_NAME }}:${{ env.RELEASE_VERSION }}
-      # Disabled due to https://github.com/go-gitea/gitea/issues/29563
-      #- name: Create manifest list and push
-      #  working-directory: /tmp/digests
-      #  run: |
-      #    echo $DOCKER_METADATA_OUTPUT_JSON
-      #    echo $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
-      #      $(printf '${{ env.CONTAINER_NAME }}@sha256:%s ' $(ls -p */* | cut -d / -f 2))
-      #    docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
-      #      $(printf '${{ env.CONTAINER_NAME }}@sha256:%s ' $(ls -p */* | cut -d / -f 2))
-      #- name: Inspect image
-      #  run: |
-      #    docker buildx imagetools inspect ${{ env.CONTAINER_NAME }}:${{ steps.meta.outputs.version }}          
-      - name: Notify
-        uses: rjstone/discord-webhook-notify@v1
-        if: failure()
-        with:
-          severity: ${{ job.status == 'success' && 'info' || (job.status == 'cancelled' && 'warn' || 'error') }}
-          details: Build ${{ job.status == 'success' && 'succeeded' || (job.status == 'cancelled' && 'cancelled' || 'failed') }}!
-          webhookUrl: ${{ secrets.DISCORD_WEBHOOK }}
-          username: Gitea
-          avatarUrl: ${{ vars.RUNNER_ICON_URL }}
-
-  Create-Release:
-    runs-on: [ubuntu-latest, linux/amd64]
-    needs: [Merge-Images]
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-      - name: Get tag
-        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-      - name: Prepare tea
-        run: |
-          # Download tea from Gitea release page
-          echo "Downloading Tea v${{ env.TEA_VERSION }}" && \
-          wget -q -O tea https://gitea.com/gitea/tea/releases/download/v${{ env.TEA_VERSION }}/tea-${{ env.TEA_VERSION }}-linux-amd64 && \
-          echo "Downloaded Tea" && \
-          chmod +x tea && \
-          # Login to Gitea
-          echo "Logging in to Gitea using Tea" && \
-          ./tea login add --name SimpleLogin --url https://git.mrmeeb.stream --token ${{ secrets.GITHUB_TOKEN }} && \
-          echo "Done"
-      - name: Make release
-        run: |
-          echo "Creating release" && \
-          ./tea release create --login "SimpleLogin" --repo ${{ env.GITHUB_REPOSITORY }} --tag ${{ env.RELEASE_VERSION }} -t ${{ env.RELEASE_VERSION }} -n "Triggered by release of v${{ env.RELEASE_VERSION }} by the SimpleLogin team. <a href=\"https://github.com/simple-login/app/releases/tag/v${{ env.RELEASE_VERSION }}\" target=\"_blank\">View the changelog</a>" && \
-          echo "Done"
-      - name: Notify
-        uses: rjstone/discord-webhook-notify@v1
-        if: failure()
-        with:
-          severity: ${{ job.status == 'success' && 'info' || (job.status == 'cancelled' && 'warn' || 'error') }}
-          details: Release ${{ job.status == 'success' && 'succeeded' || (job.status == 'cancelled' && 'cancelled' || 'failed') }}!
-          webhookUrl: ${{ secrets.DISCORD_WEBHOOK }}
-          username: Gitea
-          avatarUrl: ${{ vars.RUNNER_ICON_URL }}
-
-  Notify:
-    runs-on: ubuntu-latest
-    needs: [Build-Image, Merge-Images, Create-Release]
-    steps:
-      - name: Notify
-        uses: rjstone/discord-webhook-notify@v1
-        if: always()
-        with:
-          severity: ${{ job.status == 'success' && 'info' || (job.status == 'cancelled' && 'warn' || 'error') }}
-          details: Release ${{ job.status == 'success' && 'succeeded' || (job.status == 'cancelled' && 'cancelled' || 'failed') }}!
-          webhookUrl: ${{ secrets.DISCORD_WEBHOOK }}
-          username: Gitea
-          avatarUrl: ${{ vars.RUNNER_ICON_URL }}

app/app/account_linking.py

@@ -168,8 +168,6 @@ class NewUserStrategy(ClientMergeStrategy):
 
 class ExistingUnlinkedUserStrategy(ClientMergeStrategy):
     def process(self) -> LinkResult:
-        # IF it was scheduled to be deleted. Unschedule it.
-        self.user.delete_on = None
         partner_user = ensure_partner_user_exists_for_user(
             self.link_request, self.user, self.partner
         )
@@ -248,8 +246,6 @@ def link_user(
 ) -> LinkResult:
     # Sanitize email just in case
     link_request.email = sanitize_email(link_request.email)
-    # If it was scheduled to be deleted. Unschedule it.
-    current_user.delete_on = None
     partner_user = ensure_partner_user_exists_for_user(
         link_request, current_user, partner
     )

app/app/api/base.py

@@ -33,9 +33,6 @@ def authorize_request() -> Optional[Tuple[str, int]]:
     if g.user.disabled:
         return jsonify(error="Disabled account"), 403
 
-    if not g.user.is_active():
-        return jsonify(error="Account does not exist"), 401
-
     g.api_key = api_key
     return None
 

app/app/models.py

@@ -727,11 +727,6 @@ class User(Base, ModelMixin, UserMixin, PasswordOracle):
 
         return True
 
-    def is_active(self) -> bool:
-        if self.delete_on is None:
-            return True
-        return self.delete_on < arrow.now()
-
     def in_trial(self):
         """return True if user does not have lifetime licence or an active subscription AND is in trial period"""
         if self.lifetime_or_active_subscription():
@@ -833,9 +828,6 @@ class User(Base, ModelMixin, UserMixin, PasswordOracle):
         Whether user can create a new alias. User can't create a new alias if
         - has more than 15 aliases in the free plan, *even in the free trial*
         """
-        if not self.is_active():
-            return False
-
         if self.disabled:
             return False
 

app/app/oauth/views/authorize.py

@@ -140,7 +140,7 @@ def authorize():
                 Scope=Scope,
             )
     else:  # POST - user allows or denies
-        if not current_user.is_authenticated or not current_user.is_active():
+        if not current_user.is_authenticated or not current_user.is_active:
             LOG.i(
                 "Attempt to validate a OAUth allow request by an unauthenticated user"
             )

app/cron.py

@@ -62,8 +62,6 @@ from app.proton.utils import get_proton_partner
 from app.utils import sanitize_email
 from server import create_light_app
 
-DELETE_GRACE_DAYS = 30
-
 
 def notify_trial_end():
     for user in User.filter(
@@ -1128,19 +1126,14 @@ def notify_hibp():
         Session.commit()
 
 
-def clear_users_scheduled_to_be_deleted(dry_run=False):
+def clear_users_scheduled_to_be_deleted():
     users = User.filter(
-        and_(
-            User.delete_on.isnot(None),
-            User.delete_on <= arrow.now().shift(days=-DELETE_GRACE_DAYS),
-        )
+        and_(User.delete_on.isnot(None), User.delete_on < arrow.now())
     ).all()
     for user in users:
         LOG.i(
             f"Scheduled deletion of user {user} with scheduled delete on {user.delete_on}"
         )
-        if dry_run:
-            continue
         User.delete(user.id)
         Session.commit()
 
@@ -1213,4 +1206,4 @@ if __name__ == "__main__":
             load_unsent_mails_from_fs_and_resend()
         elif args.job == "delete_scheduled_users":
             LOG.d("Deleting users scheduled to be deleted")
-            clear_users_scheduled_to_be_deleted(dry_run=True)
+            clear_users_scheduled_to_be_deleted()

app/crontab.yml

@@ -62,7 +62,7 @@ jobs:
     captureStderr: true
 
   - name: SimpleLogin delete users scheduled to be deleted
-    command: python /code/cron.py -j delete_scheduled_users
+    command: echo disabled_user_deletion #python /code/cron.py -j delete_scheduled_users
     shell: /bin/bash
     schedule: "15 11 * * *"
     captureStderr: true

app/email_handler.py

@@ -636,10 +636,6 @@ def handle_forward(envelope, msg: Message, rcpt_to: str) -> List[Tuple[bool, str
 
     user = alias.user
 
-    if not user.is_active():
-        LOG.w(f"User {user} has been soft deleted")
-        return False, status.E502
-
     if not user.can_send_or_receive():
         LOG.i(f"User {user} cannot receive emails")
         if should_ignore_bounce(envelope.mail_from):
@@ -1059,9 +1055,6 @@ def handle_reply(envelope, msg: Message, rcpt_to: str) -> (bool, str):
     if not contact:
         LOG.w(f"No contact with {reply_email} as reverse alias")
         return False, status.E502
-    if not contact.user.is_active():
-        LOG.w(f"User {contact.user} has been soft deleted")
-        return False, status.E502
 
     alias = contact.alias
     alias_address: str = contact.alias.email
@@ -1928,9 +1921,6 @@ def handle_bounce(envelope, email_log: EmailLog, msg: Message) -> str:
         contact,
         alias,
     )
-    if not email_log.user.is_active():
-        LOG.d(f"User {email_log.user} is not active")
-        return status.E510
 
     if email_log.is_reply:
         content_type = msg.get_content_type().lower()
@@ -1992,9 +1982,6 @@ def send_no_reply_response(mail_from: str, msg: Message):
     if not mailbox:
         LOG.d("Unknown sender. Skipping reply from {}".format(NOREPLY))
         return
-    if not mailbox.user.is_active():
-        LOG.d(f"User {mailbox.user} is soft-deleted. Skipping sending reply response")
-        return
     send_email_at_most_times(
         mailbox.user,
         ALERT_TO_NOREPLY,

app/local_data/words.txt

@@ -7460,7 +7460,9 @@ villain
 vindicate
 vineyard
 vintage
+violate
 violation
+violator
 violet
 violin
 viper

app/server.py

@@ -228,8 +228,6 @@ def load_user(alternative_id):
         sentry_sdk.set_user({"email": user.email, "id": user.id})
         if user.disabled:
             return None
-        if not user.is_active():
-            return None
 
     return user
 

app/tests/test_cron.py

@@ -39,17 +39,15 @@ def test_cleanup_tokens(flask_client):
 
 def test_cleanup_users():
     u_delete_none_id = create_new_user().id
-    u_delete_grace_has_expired = create_new_user()
-    u_delete_grace_has_expired_id = u_delete_grace_has_expired.id
-    u_delete_grace_has_not_expired = create_new_user()
-    u_delete_grace_has_not_expired_id = u_delete_grace_has_not_expired.id
+    u_delete_after = create_new_user()
+    u_delete_after_id = u_delete_after.id
+    u_delete_before = create_new_user()
+    u_delete_before_id = u_delete_before.id
     now = arrow.now()
-    u_delete_grace_has_expired.delete_on = now.shift(days=-(cron.DELETE_GRACE_DAYS + 1))
-    u_delete_grace_has_not_expired.delete_on = now.shift(
-        days=-(cron.DELETE_GRACE_DAYS - 1)
-    )
+    u_delete_after.delete_on = now.shift(minutes=1)
+    u_delete_before.delete_on = now.shift(minutes=-1)
     Session.flush()
     cron.clear_users_scheduled_to_be_deleted()
     assert User.get(u_delete_none_id) is not None
-    assert User.get(u_delete_grace_has_not_expired_id) is not None
-    assert User.get(u_delete_grace_has_expired_id) is None
+    assert User.get(u_delete_after_id) is not None
+    assert User.get(u_delete_before_id) is None