4.42.0

app/tests/cron/test_get_alias_for_hibp.py

@@ -28,7 +28,7 @@ def test_get_alias_for_free_user_has_no_alias():
     assert len(aliases) == 0
 
 
-def test_get_alias_for_lifetime():
+def test_get_alias_for_lifetime_with_null_hibp_date():
     user = create_new_user()
     user.lifetime = True
     alias_id = Alias.create_new_random(user).id
@@ -39,6 +39,19 @@ def test_get_alias_for_lifetime():
     assert alias_id == aliases[0].id
 
 
+def test_get_alias_for_lifetime_with_old_hibp_date():
+    user = create_new_user()
+    user.lifetime = True
+    alias = Alias.create_new_random(user)
+    alias.hibp_last_check = arrow.now().shift(days=-1)
+    alias_id = alias.id
+    Session.commit()
+    aliases = list(
+        cron.get_alias_to_check_hibp(arrow.now(), [], alias_id, alias_id + 1)
+    )
+    assert alias_id == aliases[0].id
+
+
 def create_partner_sub(user: User):
     pu = PartnerUser.create(
         partner_id=get_proton_partner().id,
@@ -114,3 +127,16 @@ def test_skipped_user_is_not_checked():
         cron.get_alias_to_check_hibp(arrow.now(), [user.id], alias_id, alias_id + 1)
     )
     assert len(aliases) == 0
+
+
+def test_already_checked_is_not_checked():
+    user = create_new_user()
+    user.lifetime = True
+    alias = Alias.create_new_random(user)
+    alias.hibp_last_check = arrow.now().shift(days=1)
+    alias_id = alias.id
+    Session.commit()
+    aliases = list(
+        cron.get_alias_to_check_hibp(arrow.now(), [user.id], alias_id, alias_id + 1)
+    )
+    assert len(aliases) == 0